Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only inject file-level instr. for first pragma in file #865

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

cgewecke
Copy link
Member

#769

Flattened contracts often have multiple pragma statements. Since solc 0.7.x we've injected file-level instrumentation to handle file-level function declarations but this has been happening each time the parser hits a pragma resulting in:

"DeclarationError: Function with same name and parameter types defined twice.\n --> test.sol:9:1:
   |
9  | function c_true5c65fa93(bytes8 c__5c65fa93) pure returns (bool){ return true; }
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Note: Other declaration is here...
"message": "Function with same name and parameter types defined twice.",

PR adds some logic to ensure we only do this once. Also removing diamond inheritance test which didn't repro error in #769.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (351696e) 96.36% compared to head (ab272e7) 96.36%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #865   +/-   ##
=======================================
  Coverage   96.36%   96.36%           
=======================================
  Files          19       19           
  Lines        1017     1019    +2     
=======================================
+ Hits          980      982    +2     
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cgewecke cgewecke merged commit 7ad7288 into master Feb 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants